(#16) Редактирование лекции

Reviewed-on: https://git.inno-js.ru/bro-js/journal.pl/pulls/17

.gitignore

@@ -9,6 +9,8 @@ pids
 *.pid
 *.seed
 
+*prom.json
+
 # Directory for instrumented libs generated by jscoverage/JSCover
 lib-cov
 

Jenkinsfile

@@ -8,7 +8,6 @@ pipeline {
   stages {
     stage('install') {
       steps {
-        sh 'ls -a'
         sh 'node -v'
         sh 'npm -v'
         sh 'npm ci'

package-lock.json

@@ -1,12 +1,12 @@
 {
     "name": "journal.pl",
-    "version": "1.2.0",
+    "version": "2.0.0",
     "lockfileVersion": 3,
     "requires": true,
     "packages": {
         "": {
             "name": "journal.pl",
-            "version": "1.2.0",
+            "version": "2.0.0",
             "license": "MIT",
             "dependencies": {
                 "@chakra-ui/icons": "^2.1.1",

package.json

@@ -1,6 +1,6 @@
 {
     "name": "journal.pl",
-    "version": "1.2.0",
+    "version": "2.0.0",
     "description": "inno-js platform journal ui repo",
     "main": "./src/index.tsx",
     "scripts": {

src/__data__/api/api.ts

@@ -1,80 +1,120 @@
-import { createApi, fetchBaseQuery } from "@reduxjs/toolkit/query/react";
+import { createApi, fetchBaseQuery } from '@reduxjs/toolkit/query/react'
-import { getConfigValue } from "@ijl/cli";
+import { getConfigValue } from '@ijl/cli'
 
-import { keycloak } from "../kc";
+import { keycloak } from '../kc'
-import { AccessCode, BaseResponse, Course, Lesson, User, UserData } from "../model";
+import {
+  AccessCode,
+  BaseResponse,
+  Course,
+  Lesson,
+  User,
+  UserData,
+} from '../model'
 
 export const api = createApi({
-  reducerPath: "auth",
+  reducerPath: 'auth',
   baseQuery: fetchBaseQuery({
-    baseUrl: getConfigValue("journal.back.url"),
+    baseUrl: getConfigValue('journal.back.url'),
-    fetchFn: async (input: RequestInfo | URL, init?: RequestInit | undefined) => {
+    fetchFn: async (
-      const response = await fetch(input, init);
+      input: RequestInfo | URL,
+      init?: RequestInit | undefined,
+    ) => {
+      const response = await fetch(input, init)
 
       if (response.status === 403) keycloak.login()
 
-      return response;
+      return response
     },
     headers: {
-      "Content-Type": "application/json;charset=utf-8",
+      'Content-Type': 'application/json;charset=utf-8',
     },
     prepareHeaders: (headers) => {
       headers.set('Authorization', `Bearer ${keycloak.token}`)
-    }
+    },
   }),
   tagTypes: ['LessonList', 'CourseList'],
   endpoints: (builder) => ({
     coursesList: builder.query<BaseResponse<Course[]>, void>({
       query: () => '/course/list',
-      providesTags: ['CourseList']
+      providesTags: ['CourseList'],
     }),
-    createUpdateCourse: builder.mutation<BaseResponse<Course>, Partial<Course> & Pick<Course, 'name'>>({
+    createUpdateCourse: builder.mutation<
+      BaseResponse<Course>,
+      Partial<Course> & Pick<Course, 'name'>
+    >({
       query: (course) => ({
         url: '/course',
         method: 'POST',
         body: course,
       }),
-      invalidatesTags: ['CourseList']
+      invalidatesTags: ['CourseList'],
     }),
     courseAllStudents: builder.query<BaseResponse<User[]>, string>({
-      query: (courseId) => `/course/students/${courseId}`
+      query: (courseId) => `/course/students/${courseId}`,
     }),
-    manualAddStudent: builder.mutation<BaseResponse<void>, { lessonId: string, user: User }>({
+    manualAddStudent: builder.mutation<
-      query: ({lessonId, user}) => ({
+      BaseResponse<void>,
+      { lessonId: string; user: User }
+    >({
+      query: ({ lessonId, user }) => ({
         url: `/lesson/add-student/${lessonId}`,
         method: 'POST',
-        body: user
+        body: user,
-      })
+      }),
     }),
 
     lessonList: builder.query<BaseResponse<Lesson[]>, string>({
       query: (courseId) => `/lesson/list/${courseId}`,
-      providesTags: ['LessonList']
+      providesTags: ['LessonList'],
     }),
-    createLesson: builder.mutation<BaseResponse<Lesson>, Pick<Lesson, 'name' | 'date'> & { courseId: string }>({
+    createLesson: builder.mutation<
-      query: ({ name, courseId, date }) => ({
+      BaseResponse<Lesson>,
+      Partial<Lesson> & Pick<Lesson, 'name' | 'date'> & { courseId: string }
+    >({
+      query: (data) => ({
         url: '/lesson',
         method: 'POST',
-        body: { name, courseId, date },
+        body: data,
       }),
-      invalidatesTags: ['LessonList']
+      invalidatesTags: ['LessonList'],
+    }),
+    updateLesson: builder.mutation<BaseResponse<Lesson>, Partial<Lesson> & Pick<Lesson, '_id'>>({
+      query: (data) => ({
+        method: 'PUT',
+        url: `/lesson/${data._id}`,
+        body: data,
+      }),
+      invalidatesTags: ['LessonList'],
+    }),
+    deleteLesson: builder.mutation<null, string>({
+      query: (lessonId) => ({
+        url: `/lesson/${lessonId}`,
+        method: 'DELETE',
+      }),
+      invalidatesTags: ['LessonList'],
     }),
     lessonById: builder.query<BaseResponse<Lesson>, string>({
-      query: (lessonId: string) => `/lesson/${lessonId}`
+      query: (lessonId: string) => `/lesson/${lessonId}`,
     }),
 
-    createAccessCode: builder.query<BaseResponse<AccessCode>, { lessonId: string }>({
+    createAccessCode: builder.query<
+      BaseResponse<AccessCode>,
+      { lessonId: string }
+    >({
       query: ({ lessonId }) => ({
         url: '/lesson/access-code',
         method: 'POST',
         body: { lessonId },
-      })
       }),
-    getAccess: builder.query<BaseResponse<{ user: UserData, accessCode: AccessCode }>, { accessCode: string }>({
+    }),
+    getAccess: builder.query<
+      BaseResponse<{ user: UserData; accessCode: AccessCode }>,
+      { accessCode: string }
+    >({
       query: ({ accessCode }) => ({
         url: `/lesson/access-code/${accessCode}`,
         method: 'GET',
-      })
-    })
       }),
-});
+    }),
+  }),
+})

src/pages/course-list.tsx

@@ -35,6 +35,7 @@ import { useAppSelector } from '../__data__/store'
 import { api } from '../__data__/api/api'
 import { isTeacher } from '../utils/user'
 import { AddIcon, ArrowDownIcon, ArrowUpIcon, LinkIcon } from '@chakra-ui/icons'
+import { Course } from '../__data__/model'
 
 interface NewCourseForm {
   startDt: string
@@ -226,7 +227,15 @@ const CoursesList = () => {
   )
 }
 
-const CourseCard = ({ course, isOpened, openDetails }) => {
+const CourseCard = ({
+  course,
+  isOpened,
+  openDetails,
+}: {
+  course: Course
+  isOpened: boolean
+  openDetails: () => void
+}) => {
   const [getLessonList, lessonList] = api.useLazyLessonListQuery()
   useEffect(() => {
     if (isOpened) {
@@ -262,6 +271,7 @@ const CourseCard = ({ course, isOpened, openDetails }) => {
                   {lessonList.data?.body?.map((lesson) => (
                     <Link
                       as={ConnectedLink}
+                      key={lesson._id}
                       to={
                         isTeacher(user)
                           ? `${getNavigationsValue('journal.main')}/lesson/${course._id}/${lesson._id}`

src/pages/lesson-details.tsx

@@ -20,6 +20,7 @@ import {
   Lessonname,
   AddMissedButton,
   UnorderList,
+  BreadcrumbsWrapper,
 } from './style'
 import { api } from '../__data__/api/api'
 import { User } from '../__data__/model'
@@ -86,8 +87,8 @@ const LessonDetail = () => {
   }, [accessCode?.body, AllStudents.data])
 
   return (
-    <Container maxW="container.xl" centerContent px="200">
+    <>
-      <VStack align="left">
+      <BreadcrumbsWrapper>
         <Breadcrumb>
           <BreadcrumbItem>
             <BreadcrumbLink as={Link} to={getNavigationsValue('journal.main')}>
@@ -108,16 +109,19 @@ const LessonDetail = () => {
             <BreadcrumbLink href="#">Лекция</BreadcrumbLink>
           </BreadcrumbItem>
         </Breadcrumb>
-        <Heading as='h3' mt='4' mb='3'>
+      </BreadcrumbsWrapper>
+      <Container maxW="container.xl" centerContent px="200">
+        <VStack align="left">
+          <Heading as="h3" mt="4" mb="3">
             Тема занятия:
           </Heading>
+          <Box as="span">{accessCode?.body?.lesson?.name}</Box>
           <Box as="span">
-          {accessCode?.body?.lesson?.name}
-        </Box>
-        <Box as='span'>
             {dayjs(accessCode?.body?.lesson?.date).format('DD MMMM YYYYг.')}{' '}
             Отмечено - {accessCode?.body?.lesson?.students?.length}{' '}
-          {AllStudents.isSuccess ? `/ ${AllStudents?.data?.body?.length}` : ''}{' '}
+            {AllStudents.isSuccess
+              ? `/ ${AllStudents?.data?.body?.length}`
+              : ''}{' '}
             человек
           </Box>
         </VStack>
@@ -143,6 +147,7 @@ const LessonDetail = () => {
           </UnorderList>
         </HStack>
       </Container>
+    </>
   )
 }
 

src/pages/lesson-list.tsx

@@ -14,108 +14,91 @@ import {
   CardHeader,
   Heading,
   Button,
-  ButtonGroup,
   CloseButton,
   useToast,
-  Stack,
   VStack,
   FormControl,
   FormLabel,
+  Toast,
   FormHelperText,
   FormErrorMessage,
   Input,
+  TableContainer,
+  Table,
+  Thead,
+  Tr,
+  Th,
+  Tbody,
+  Td,
+  Menu,
+  MenuButton,
+  MenuItem,
+  Text,
+  MenuList,
+  Center,
+  Spinner,
+  AlertDialog,
+  AlertDialogBody,
+  AlertDialogContent,
+  AlertDialogFooter,
+  AlertDialogHeader,
+  AlertDialogOverlay,
 } from '@chakra-ui/react'
+import { AddIcon, EditIcon } from '@chakra-ui/icons'
 
-import { AddIcon } from '@chakra-ui/icons'
-
-import { LessonItem, Lessonname, ErrorSpan } from './style'
-
-import { keycloak } from '../__data__/kc'
 import { useAppSelector } from '../__data__/store'
 import { api } from '../__data__/api/api'
 import { isTeacher } from '../utils/user'
+import { qrCode } from '../assets'
+import { Lesson } from '../__data__/model'
+
+import { ErrorSpan, BreadcrumbsWrapper } from './style'
 
 interface NewLessonForm {
   name: string
   date: string
 }
 
-const LessonList = () => {
+interface LessonFormProps {
-  const { courseId } = useParams()
+  lesson?: Partial<Lesson>
-  const user = useAppSelector((s) => s.user)
+  isLoading: boolean
-  const { data, isLoading, error } = api.useLessonListQuery(courseId)
+  onCancel: () => void
-  const [createLesson, crLQuery] = api.useCreateLessonMutation()
+  onSubmit: (lesson: Lesson) => void
-  const [value, setValue] = useState('')
+  error?: string
-  const [showForm, setShowForm] = useState(false)
+}
+
+const LessonForm = ({
+  lesson,
+  isLoading,
+  onCancel,
+  onSubmit,
+  error,
+}: LessonFormProps) => {
   const {
     control,
     handleSubmit,
     reset,
     formState: { errors },
-    getValues,
   } = useForm<NewLessonForm>({
-    defaultValues: {
+    defaultValues: lesson || {
       name: '',
       date: '',
     },
   })
-  const toast = useToast()
-  const toastRef = useRef(null)
-
-  const handleChange = useCallback(
-    (event) => {
-      setValue(event.target.value.toUpperCase())
-    },
-    [setValue],
-  )
-  const onSubmit = ({ name, date }) => {
-    toastRef.current = toast({
-      title: 'Отправляем',
-      status: 'loading',
-      duration: 9000,
-    })
-    createLesson({ name, courseId, date })
-  }
-
-  useEffect(() => {
-    if (crLQuery.isSuccess) {
-      const values = getValues()
-      if (toastRef.current) {
-        toast.update(toastRef.current, {
-          title: 'Лекция создана',
-          description: `Лекция ${values.name} успешно создана`,
-          status: 'success',
-          duration: 9000,
-          isClosable: true,
-        })
-      }
-      reset()
-    }
-  }, [crLQuery.isSuccess])
 
   return (
-    <Container maxW="container.xl">
-      <Breadcrumb>
-        <BreadcrumbItem>
-          <BreadcrumbLink as={Link} to={getNavigationsValue('journal.main')}>
-            Журнал
-          </BreadcrumbLink>
-        </BreadcrumbItem>
-
-        <BreadcrumbItem isCurrentPage>
-          <BreadcrumbLink href="#">Курс</BreadcrumbLink>
-        </BreadcrumbItem>
-      </Breadcrumb>
-
-      {isTeacher(user) && (
-        <Box mt="15" mb="15">
-          {showForm ? (
     <Card align="left">
       <CardHeader display="flex">
         <Heading as="h2" mt="0">
           Создание лекции
         </Heading>
-                <CloseButton ml="auto" onClick={() => setShowForm(false)} />
+        <CloseButton
+          ml="auto"
+          onClick={() => {
+            reset()
+            onCancel()
+          }}
+        />
       </CardHeader>
       <CardBody>
         <form onSubmit={handleSubmit(onSubmit)}>
@@ -135,13 +118,9 @@ const LessonList = () => {
                     type="datetime-local"
                   />
                   {errors.date ? (
-                            <FormErrorMessage>
+                    <FormErrorMessage>{errors.date?.message}</FormErrorMessage>
-                              {errors.date?.message}
-                            </FormErrorMessage>
                   ) : (
-                            <FormHelperText>
+                    <FormHelperText>Укажите дату и время лекции</FormHelperText>
-                              Укажите дату и время лекции
-                            </FormHelperText>
                   )}
                 </FormControl>
               )}
@@ -152,10 +131,7 @@ const LessonList = () => {
               name="name"
               rules={{ required: 'Обязательное поле' }}
               render={({ field }) => (
-                        <FormControl
+                <FormControl isRequired isInvalid={Boolean(errors.name)}>
-                          isRequired
-                          isInvalid={Boolean(errors.name)}
-                        >
                   <FormLabel>Название новой лекции:</FormLabel>
                   <Input
                     {...field}
@@ -164,9 +140,7 @@ const LessonList = () => {
                     size="md"
                   />
                   {errors.name && (
-                            <FormErrorMessage>
+                    <FormErrorMessage>{errors.name.message}</FormErrorMessage>
-                              {errors.name.message}
-                            </FormErrorMessage>
                   )}
                 </FormControl>
               )}
@@ -177,18 +151,199 @@ const LessonList = () => {
                 type="submit"
                 leftIcon={<AddIcon />}
                 colorScheme="blue"
+                isLoading={isLoading}
               >
                 Создать
               </Button>
             </Box>
           </VStack>
 
-                  {crLQuery.error && (
+          {error && <ErrorSpan>{error}</ErrorSpan>}
-                    <ErrorSpan>{(crLQuery.error as any).error}</ErrorSpan>
-                  )}
         </form>
       </CardBody>
     </Card>
+  )
+}
+
+const LessonList = () => {
+  const { courseId } = useParams()
+  const user = useAppSelector((s) => s.user)
+  const { data, isLoading, error } = api.useLessonListQuery(courseId)
+  const [createLesson, crLQuery] = api.useCreateLessonMutation()
+  const [deleteLesson, deletingRqst] = api.useDeleteLessonMutation()
+  const [updateLesson, updateLessonRqst] = api.useUpdateLessonMutation()
+  const [showForm, setShowForm] = useState(false)
+  const [lessonToDelete, setlessonToDelete] = useState<Lesson>(null)
+  const cancelRef = React.useRef()
+  const toast = useToast()
+  const toastRef = useRef(null)
+  const createdLessonRef = useRef(null)
+  const [editLesson, setEditLesson] = useState<Lesson>(null)
+
+  const onSubmit = (lessonData) => {
+    toastRef.current = toast({
+      title: 'Отправляем',
+      status: 'loading',
+      duration: 9000,
+    })
+    createdLessonRef.current = lessonData
+    if (editLesson) updateLesson(lessonData)
+    else createLesson({ courseId, ...lessonData })
+  }
+
+  useEffect(() => {
+    if (deletingRqst.isError) {
+      toast({
+        title: (deletingRqst.error as any)?.error,
+        status: 'error',
+        duration: 3000,
+      })
+    }
+
+    if (deletingRqst.isSuccess) {
+      const lesson = { ...lessonToDelete }
+      toast({
+        status: 'warning',
+        duration: 9000,
+        render: ({ id, ...toastProps }) => (
+          <Toast
+            {...toastProps}
+            id={id}
+            title={
+              <>
+                <Box pb={3}>
+                  <Text fontSize="xl">{`Удалена лекция ${lesson.name}`}</Text>
+                </Box>
+                <Button
+                  onClick={() => {
+                    createLesson({ courseId, ...lesson })
+                    toast.close(id)
+                  }}
+                >
+                  Восстановить
+                </Button>
+              </>
+            }
+          />
+        ),
+      })
+      setlessonToDelete(null)
+    }
+  }, [deletingRqst.isLoading, deletingRqst.isSuccess, deletingRqst.isError])
+
+  useEffect(() => {
+    if (crLQuery.isSuccess) {
+      const toastProps = {
+        title: 'Лекция создана',
+        description: `Лекция ${createdLessonRef.current.name} успешно создана`,
+        status: 'success' as 'success',
+        duration: 9000,
+        isClosable: true,
+      }
+      if (toastRef.current) toast.update(toastRef.current, toastProps)
+      else toast(toastProps)
+      setShowForm(false)
+    }
+  }, [crLQuery.isSuccess])
+
+  useEffect(() => {
+    if (updateLessonRqst.isSuccess) {
+      const toastProps = {
+        title: 'Лекция Обновлена',
+        description: `Лекция ${createdLessonRef.current.name} успешно обновлена`,
+        status: 'success' as 'success',
+        duration: 9000,
+        isClosable: true,
+      }
+      if (toastRef.current) toast.update(toastRef.current, toastProps)
+      else toast(toastProps)
+      setShowForm(false)
+    }
+  }, [updateLessonRqst.isSuccess])
+
+  if (isLoading) {
+    return (
+      <Container maxW="container.xl">
+        <Center h="300px">
+          <Spinner
+            thickness="4px"
+            speed="0.65s"
+            emptyColor="gray.200"
+            color="blue.500"
+            size="xl"
+          />
+        </Center>
+      </Container>
+    )
+  }
+
+  return (
+    <>
+      <AlertDialog
+        isOpen={Boolean(lessonToDelete)}
+        leastDestructiveRef={cancelRef}
+        onClose={() => setlessonToDelete(null)}
+      >
+        <AlertDialogOverlay>
+          <AlertDialogContent>
+            <AlertDialogHeader fontSize="lg" fontWeight="bold">
+              Удалить занятие от{' '}
+              {dayjs(lessonToDelete?.date).format('DD.MM.YY')}?
+            </AlertDialogHeader>
+
+            <AlertDialogBody>
+              Все данные о посещении данного занятия будут удалены
+            </AlertDialogBody>
+
+            <AlertDialogFooter>
+              <Button
+                isDisabled={deletingRqst.isLoading}
+                ref={cancelRef}
+                onClick={() => setlessonToDelete(null)}
+              >
+                Cancel
+              </Button>
+              <Button
+                colorScheme="red"
+                loadingText=""
+                isLoading={deletingRqst.isLoading}
+                onClick={() => deleteLesson(lessonToDelete._id)}
+                ml={3}
+              >
+                Delete
+              </Button>
+            </AlertDialogFooter>
+          </AlertDialogContent>
+        </AlertDialogOverlay>
+      </AlertDialog>
+      <BreadcrumbsWrapper>
+        <Breadcrumb>
+          <BreadcrumbItem>
+            <BreadcrumbLink as={Link} to={getNavigationsValue('journal.main')}>
+              Журнал
+            </BreadcrumbLink>
+          </BreadcrumbItem>
+
+          <BreadcrumbItem isCurrentPage>
+            <BreadcrumbLink href="#">Курс</BreadcrumbLink>
+          </BreadcrumbItem>
+        </Breadcrumb>
+      </BreadcrumbsWrapper>
+      <Container maxW="container.xl">
+        {isTeacher(user) && (
+          <Box mt="15" mb="15">
+            {showForm ? (
+              <LessonForm
+                key={editLesson?._id}
+                isLoading={crLQuery.isLoading}
+                onSubmit={onSubmit}
+                onCancel={() => {
+                  setShowForm(false)
+                  setEditLesson(null)
+                }}
+                error={(crLQuery.error as any)?.error}
+                lesson={editLesson}
+              />
             ) : (
               <Box p="2" m="2">
                 <Button
@@ -202,27 +357,72 @@ const LessonList = () => {
             )}
           </Box>
         )}
-      <ul style={{ paddingLeft: 0 }}>
+        <TableContainer whiteSpace="wrap">
+          <Table variant="striped" colorScheme="cyan">
+            <Thead>
+              <Tr>
+                {isTeacher(user) && (
+                  <Th align="center" width={1}>
+                    ссылка
+                  </Th>
+                )}
+                <Th textAlign="center" width={1}>
+                  Дата
+                </Th>
+                <Th>Название</Th>
+                <Th>action</Th>
+                <Th isNumeric>Отмечено</Th>
+              </Tr>
+            </Thead>
+            <Tbody>
               {data?.body?.map((lesson) => (
-          <LessonItem key={lesson._id}>
+                <Tr key={lesson._id}>
+                  {isTeacher(user) && (
+                    <Td>
                       <Link
-              to={
+                        to={`${getNavigationsValue('journal.main')}/lesson/${courseId}/${lesson._id}`}
-                isTeacher(user)
-                  ? `${getNavigationsValue('journal.main')}/lesson/${courseId}/${lesson._id}`
-                  : ''
-              }
                         style={{ display: 'flex' }}
                       >
-              <Lessonname>{lesson.name}</Lessonname>
+                        <img
-              <span>{dayjs(lesson.date).format('DD MMMM YYYYг.')}</span>
+                          width={24}
-              <span style={{ marginLeft: 'auto' }}>
+                          src={qrCode}
-                Участников - {lesson.students.length}
+                          style={{ margin: '0 auto' }}
-              </span>
+                        />
                       </Link>
-          </LessonItem>
+                    </Td>
+                  )}
+                  <Td textAlign="center">
+                    {dayjs(lesson.date).format('H:mm DD.MM.YY')}
+                  </Td>
+                  <Td>{lesson.name}</Td>
+                  <Td>
+                    <Menu>
+                      <MenuButton as={Button}>
+                        <EditIcon />
+                      </MenuButton>
+                      <MenuList>
+                        <MenuItem
+                          onClick={() => {
+                            setShowForm(true)
+                            setEditLesson(lesson)
+                          }}
+                        >
+                          Edit
+                        </MenuItem>
+                        <MenuItem onClick={() => setlessonToDelete(lesson)}>
+                          Delete
+                        </MenuItem>
+                      </MenuList>
+                    </Menu>
+                  </Td>
+                  <Td isNumeric>{lesson.students.length}</Td>
+                </Tr>
               ))}
-      </ul>
+            </Tbody>
+          </Table>
+        </TableContainer>
       </Container>
+    </>
   )
 }
 

src/pages/style.ts

@@ -4,6 +4,9 @@ import {
   Card
 } from '@chakra-ui/react'
 
+export const BreadcrumbsWrapper = styled.div`
+  padding: 12px;
+`;
 
 export const MainWrapper = styled.main`
   display: flex;

stubs/api/index.js

@@ -45,4 +45,12 @@ router.get('/lesson/:lessonId', (req, res) => {
   res.send(require('../mocks/lessons/byid/success.json'))
 })
 
+router.delete('/lesson/:lessonId', (req, res) => {
+  res.send({ success: true, body: { ok: true }})
+})
+
+router.put('/lesson/:lessonId', (req, res) => {
+  res.send({ success: true, body: req.body })
+})
+
 module.exports = router