bro-students/multy-stub
bro-students/multy-stub
28
0
Fork 2
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remove try-catch

Browse Source
This commit is contained in:
RustamRu 2025-01-19 11:45:42 +03:00
parent 949416d2a3
commit 98daf19853
1 changed files with 52 additions and 73 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

125
server/routers/dry-wash/order.js
View File

@ -74,7 +74,7 @@ const VALIDATION_MESSAGES = {
}, },
} }
router.post('/create', async (req, res, next) => { router.post('/create', async (req, res) => {
const bodyErrors = [] const bodyErrors = []
const { customer } = req.body const { customer } = req.body
@ -120,46 +120,37 @@ router.post('/create', async (req, res, next) => {
throw new Error(bodyErrors.join(', ')) throw new Error(bodyErrors.join(', '))
} }
try { const order = await OrderModel.create({
const order = await OrderModel.create({ phone: customer.phone,
phone: customer.phone, carNumber: car.number,
carNumber: car.number, carBody: car.body,
carBody: car.body, carColor: car.color,
carColor: car.color, startWashTime: washing.begin,
startWashTime: washing.begin, endWashTime: washing.end,
endWashTime: washing.end, location: washing.location,
location: washing.location, status: orderStatus.PROGRESS,
status: orderStatus.PROGRESS, notes: '',
notes: '', created: new Date().toISOString(),
created: new Date().toISOString(), })
})
res.status(200).send({ success: true, body: order }) res.status(200).send({ success: true, body: order })
} catch (error) {
next(error)
}
}) })
router.get('/:id', async (req, res, next) => { router.get('/:id', async (req, res) => {
const { id } = req.params const { id } = req.params
if (!mongoose.Types.ObjectId.isValid(id)) { if (!mongoose.Types.ObjectId.isValid(id)) {
throw new Error(VALIDATION_MESSAGES.orderId.invalid) throw new Error(VALIDATION_MESSAGES.orderId.invalid)
} }
try { const order = await OrderModel.findById(id)
const order = await OrderModel.findById(id) if (!order) {
if (!order) { throw new Error(VALIDATION_MESSAGES.order.notFound)
throw new Error(VALIDATION_MESSAGES.order.notFound)
}
res.status(200).send({ success: true, body: order })
} catch (error) {
next(error)
} }
res.status(200).send({ success: true, body: order })
}) })
router.patch('/:id', async (req, res, next) => { router.patch('/:id', async (req, res) => {
const { id } = req.params const { id } = req.params
if (!mongoose.Types.ObjectId.isValid(id)) { if (!mongoose.Types.ObjectId.isValid(id)) {
throw new Error(VALIDATION_MESSAGES.orderId.invalid) throw new Error(VALIDATION_MESSAGES.orderId.invalid)
@ -179,13 +170,9 @@ router.patch('/:id', async (req, res, next) => {
if (!mongoose.Types.ObjectId.isValid(masterId)) { if (!mongoose.Types.ObjectId.isValid(masterId)) {
bodyErrors.push(VALIDATION_MESSAGES.masterId.invalid) bodyErrors.push(VALIDATION_MESSAGES.masterId.invalid)
} else { } else {
try { const master = await MasterModel.findById(masterId)
const master = await MasterModel.findById(masterId) if (!master) {
if (!master) { bodyErrors.push(VALIDATION_MESSAGES.master.notFound)
bodyErrors.push(VALIDATION_MESSAGES.master.notFound)
}
} catch (error) {
next(error)
} }
} }
} }
@ -201,51 +188,43 @@ router.patch('/:id', async (req, res, next) => {
throw new Error(bodyErrors.join(', ')) throw new Error(bodyErrors.join(', '))
} }
try { const updateData = {}
const updateData = {} if (status) {
if (status) { updateData.status = status
updateData.status = status
}
if (masterId) {
updateData.master = masterId
}
if (notes) {
updateData.notes = notes
}
updateData.updated = new Date().toISOString()
const order = await OrderModel.findByIdAndUpdate(
id,
updateData,
{ new: true }
)
if (!order) {
throw new Error(VALIDATION_MESSAGES.order.notFound)
}
res.status(200).send({ success: true, body: order })
} catch (error) {
next(error)
} }
if (masterId) {
updateData.master = masterId
}
if (notes) {
updateData.notes = notes
}
updateData.updated = new Date().toISOString()
const order = await OrderModel.findByIdAndUpdate(
id,
updateData,
{ new: true }
)
if (!order) {
throw new Error(VALIDATION_MESSAGES.order.notFound)
}
res.status(200).send({ success: true, body: order })
}) })
router.delete('/:id', async (req, res, next) => { router.delete('/:id', async (req, res) => {
const { id } = req.params const { id } = req.params
if (!mongoose.Types.ObjectId.isValid(id)) { if (!mongoose.Types.ObjectId.isValid(id)) {
throw new Error(VALIDATION_MESSAGES.orderId.invalid) throw new Error(VALIDATION_MESSAGES.orderId.invalid)
} }
try { const order = await OrderModel.findByIdAndDelete(id, {
const order = await OrderModel.findByIdAndDelete(id, { new: true,
new: true, })
}) if (!order) {
if (!order) { throw new Error(VALIDATION_MESSAGES.order.notFound)
throw new Error(VALIDATION_MESSAGES.order.notFound)
}
res.status(200).send({ success: true, body: order })
} catch (error) {
next(error)
} }
res.status(200).send({ success: true, body: order })
}) })
module.exports = router module.exports = router